Fix week() calculation to start week 1 at days 1–7 #7274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7274 +/- ##
=======================================
Coverage 99.10% 99.10%
=======================================
Files 84 84
Lines 16128 16128
=======================================
Hits 15983 15983
Misses 145 145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 6c570ce Download link for the artifact containing the test results: ↓ atime-results.zip
|
tdhock
changed the title
|
@venom1204 please resolve conflicts @MichaelChirico can you please review because you posted the issue this fixes? |
…o issue____2611
|
@tdhock done |
|
Doesn't LGTM because it is a breaking change, not even documented. Maybe we can detect breaking behavior and raise warning that can be suppressed with a temporary global option? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2611
This PR fixes the long-standing bug in week() (#2611) by defining weeks sequentially: days 1–7 are week 1, days 8–14 week 2, etc.
hi @MichaelChirico @tdhock can you please have a review when you got time .
thanks.